Release v1.4.4: Theme Switcher menu variant#38
Merged
Merged
Conversation
Add icon-only menu UI for theme selection, component CSS, Playwright coverage, PR smoke CI split, and release documentation updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge All previous issues have been addressed in the two follow-up commits:
Files Reviewed (2 source files + 14 dist files)
Reviewed by deepseek-v4-pro-20260423 · 379,779 tokens |
Normalize getMenuSwitchers root like getToggles for scoped init, and refresh opt-in tooltip labels via the public Tooltips.update method. Co-authored-by: Cursor <cursoragent@cursor.com>
Use primary background for the menu panel and secondary for option hover in dark and system-dark modes for clearer contrast. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vd-theme-switcher[data-theme-ui="menu"]) with newtheme-switcher.css, keyboard nav, and optional tooltipsmainTest plan
pnpm run lint && pnpm run build && pnpm run check:versionspnpm test(theme-switcher spec on Chromium Desktop)mainMade with Cursor