Update the site maps addon to point to discussions directly #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a feature flag to render site maps that point to discussions directly rather than category archives (see SitemapsPlugin::DISCUSSION_SITE_MAPS) for the feature name. The reason for this change is: 1. We get several complaints about the category archive pages not allowing indexing because that shows as an error in Google Webmaster tools after a more recent change. 2. There is an edge case where we may want to disallow access to most of the site except discussions for certain SEO trickery. This change is being put behind a feature flag because it impacts SEO and whenever we make a change to SEO related functionality we don’t know whether the change will be good, bad, or neutral so we have to take care and roll it out slowly.
igraziatto
approved these changes
Jun 5, 2020
Contributor
Author
|
I wonder if you need to merge master into this to get the build working? |
initvector
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag to render site maps that point to discussions directly rather than category archives (see SitemapsPlugin::DISCUSSION_SITE_MAPS) for the feature name.
The new sitemaps use the index to point to categories that page discussions by a limit of 1000 which is a number we may tweak. This ends up putting more entries in the site map index too (as much as ~6000 for some sites), but the hope is since the sitemap index is largely generated programmatically we should be okay with performance.
The reason for this change is:
This change is being put behind a feature flag because it impacts SEO and whenever we make a change to SEO related functionality we don’t know whether the change will be good, bad, or neutral so we have to take care and roll it out slowly.