Fix looping when JSConnect fails and site has Private Community turned on. #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en JSConnect fails and site has Private Community turned on.
blutarch
approved these changes
Mar 3, 2020
Member
blutarch
left a comment
blutarch
left a comment
There was a problem hiding this comment.
Tested this locally and it looks good.
nervoustwit
added
Domain: Registration/Signin
Type: Technical Debt
initvector
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #776
This PR will fix looping when trying to log in by passing a flag to the JSConnect JavaScript if it is a Private Community which will not redirect the browser if there is an error.
Also, this PR will add console logging if an Admin has put the JSConnect plugin in Test Mode.
To test
UniqueID.Test console logging.