Skip to content

Conversation

@igraziatto
Copy link
Contributor

Closes https://github.com/vanilla/support/issues/728

Steps to test:

  • Enable Signature addon
  • Set the maximum number of characters to 5
  • Try and update a signature to 0 or 1 characters
  • You will get a "Signature is X characters too long" error
  • Checkout this branch try again to see the issue resolve

Further testing:

  • Try the same process above in a different posting format

@igraziatto igraziatto requested a review from a team March 11, 2020 19:57
@blutarch blutarch assigned blutarch and unassigned blutarch Mar 11, 2020
@blutarch blutarch self-requested a review March 11, 2020 20:04
Copy link
Member

@blutarch blutarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works.

@initvector initvector requested a review from nervoustwit March 12, 2020 14:05
@initvector
Copy link
Contributor

Two approvals. I am assuming this is cool to merge.

@initvector initvector merged commit 282e587 into master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants