Skip to content

Conversation

@OlivierLamyCanuel
Copy link
Contributor

@OlivierLamyCanuel OlivierLamyCanuel commented Apr 13, 2022

Issue

Two functions from the IPBFormatter plugin were triggering this error:

Parameter 2 to IPBFormatterPlugin::editorPlugin_getJSDefinitions_handler() expected to be a reference, value given.

Both functions were expecting the $args argument to be a reference.

See: https://higherlogic.atlassian.net/browse/VNLA-1220

Solution

  • Use the value rather than the reference in the function signature.

QA

  • Set debug mode on
  • Enable the Advanced Editor plugin and IPBFormatter plugin.
  • Notice the error message showing up about those two functions.
  • Check out this branch, notice the message is gone.

Addidionnal QA

  • Set the posting type to IPB.
  • Post content in the IPB format.
  • Notice that the post is rendered properly.

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022

CLA assistant check
All committers have signed the CLA.

@OlivierLamyCanuel OlivierLamyCanuel merged commit dcf5c03 into master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants