Implement CSP 'frame-ancestors' header for Gdn_Controller#8970
Merged
Conversation
…rd checks and headers apply CSP 'frame-ancestors' header for Gdn_Controller Closes: https://github.com/vanilla/vanilla-patches/issues/551
alex-mtl
added
Status: WIP
alex-mtl
added
Release: DB Update
charrondev
added
the
Release: Custom Notes
charrondev
suggested changes
Jun 19, 2019
| $hsts = Gdn::factory('HstsModel'); | ||
| $this->_Headers[HttpStrictTransportSecurityModel::HSTS_HEADER] = $hsts->getHsts(); | ||
|
|
||
| $cspModel = Gdn::factory(ContentSecurityPolicyModel::class); |
Contributor
There was a problem hiding this comment.
I'm trying to get rid of Gdn::factory() (it just uses the container internally at this point). #7459
The standard way for this is Gdn::getContainer()->get() instead.
according to code review
charrondev
approved these changes
Jun 19, 2019
initvector
approved these changes
Jun 19, 2019
Merged
charrondev
added
Status: Backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
These are mostly important for the OSS release.
Upgrade Notes
container.htmlfrom the root of the vanilla installation./utility/update.PR
Output
container.htmlpage through GDN_Controller to apply all standard checks and headersapply CSP 'frame-ancestors' header for
Gdn_ControllerCloses: https://github.com/vanilla/vanilla-patches/issues/551
Note Require to run utility/update to add new route for container.html (no DB change)