Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 37 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough该PR进行了大规模文档整理和工作流调整：删除了HTTP/3阶段规划相关的多个文档文件，移除了发布流程中的每个标签自定义说明支持，更新README以反映新的平台信息和命令，并调整了模块化相关文档。 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes archived / one-off documentation and aligns the repository’s README + docs index to reflect the current “single-binary” project shape, while simplifying the GitHub Release body generation.
Changes:
- Prune stale HTTP/3 phase/alignment docs, upstream HTTP/3 plan docs, an old curated release notes file, and the obsolete
run-http3-phase0.shscript. - Rewrite
README.mdanddocs/README.mdto only describe current repository structure and active, long-lived governance docs. - Simplify
.github/workflows/release.ymlrelease-body generation by dropping the optional curatedRELEASE_NOTES_<tag>.mdprepend behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/run-http3-release-gate.sh |
Updates usage text to remove phase-specific wording while keeping current gate behavior unchanged. |
scripts/run-http3-phase0.sh |
Removes obsolete phase-0 baseline runner entrypoint. |
scripts/run-http3-gate.sh |
Updates admin test label wording to remove stale “control plane” phrasing. |
docs/README.md |
Rewrites docs index to only list active, long-lived governance documentation. |
docs/HTTP3_PHASE7_RELEASE.md |
Removes archived phase-7 release-gate doc. |
docs/HTTP3_PHASE0_BASELINE.md |
Removes archived phase-0 baseline doc. |
docs/ARCHITECTURE_UPSTREAM_HTTP3_PRODUCTION_PLAN.md |
Removes completed upstream HTTP/3 plan doc. |
docs/ARCHITECTURE_UPSTREAM_HTTP3_PHASE0_BASELINE.md |
Removes archived upstream phase-0 baseline doc. |
docs/ARCHITECTURE_MODULE_LAYOUT_GUIDE.md |
Removes phase-specific wording to make the guide timeless. |
docs/ARCHITECTURE_HTTP3_NGINX_ALIGNMENT_PLAN.md |
Removes completed HTTP/3 alignment plan doc. |
docs/ARCHITECTURE_CODEBASE_MODULARIZATION_POLICY.md |
Updates policy wording to stand alone (no longer framed as “plan phase 0”) and clarifies baseline file semantics. |
docs/ARCHITECTURE_CODEBASE_MODULARIZATION_PLAN.md |
Removes completed modularization plan doc. |
RELEASE_NOTES_v0.1.3-rc.13.md |
Removes one-off curated release notes file. |
README.md |
Aligns top-level README to current repo shape, adds install instructions, and refreshes command/examples and docs links. |
.github/workflows/release.yml |
Simplifies release body generation and renames the step to match output (“Release Body”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 18: The README currently lists the local read-only admin commands
including peers and upstreams but the example commands section omits them;
update the examples to include usage for the peers and upstreams commands (e.g.,
show a sample invocation for peers and for upstreams including the --window-secs
flag) and/or add a short note in the capability overview explaining the purpose
of peers and upstreams so the list and examples are consistent with the CLI
implementation (referencing the peers and upstreams command names and the
--window-secs parameter).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: d02033bf-f06f-475e-a35f-f6cc5c8d566e
📒 Files selected for processing (15)
.github/workflows/release.ymlREADME.mdRELEASE_NOTES_v0.1.3-rc.13.mddocs/ARCHITECTURE_CODEBASE_MODULARIZATION_PLAN.mddocs/ARCHITECTURE_CODEBASE_MODULARIZATION_POLICY.mddocs/ARCHITECTURE_HTTP3_NGINX_ALIGNMENT_PLAN.mddocs/ARCHITECTURE_MODULE_LAYOUT_GUIDE.mddocs/ARCHITECTURE_UPSTREAM_HTTP3_PHASE0_BASELINE.mddocs/ARCHITECTURE_UPSTREAM_HTTP3_PRODUCTION_PLAN.mddocs/HTTP3_PHASE0_BASELINE.mddocs/HTTP3_PHASE7_RELEASE.mddocs/README.mdscripts/run-http3-gate.shscripts/run-http3-phase0.shscripts/run-http3-release-gate.sh
💤 Files with no reviewable changes (8)
- docs/ARCHITECTURE_CODEBASE_MODULARIZATION_PLAN.md
- RELEASE_NOTES_v0.1.3-rc.13.md
- docs/ARCHITECTURE_UPSTREAM_HTTP3_PRODUCTION_PLAN.md
- docs/HTTP3_PHASE0_BASELINE.md
- scripts/run-http3-phase0.sh
- docs/ARCHITECTURE_UPSTREAM_HTTP3_PHASE0_BASELINE.md
- docs/ARCHITECTURE_HTTP3_NGINX_ALIGNMENT_PLAN.md
- docs/HTTP3_PHASE7_RELEASE.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Agent
- GitHub Check: Test Fast
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-04-13T10:53:29.903Z
Learnt from: vansour
Repo: vansour/rginx PR: 43
File: crates/rginx-config/src/validate/server.rs:421-439
Timestamp: 2026-04-13T10:53:29.903Z
Learning: In `crates/rginx-config/src/validate/server.rs` (`validate_http3`), the check for `tls.session_tickets` when `http3.early_data = true` intentionally only rejects `Some(true)` and allows `None`. Requiring `Some(false)` breaks 0-RTT resumption and the `routes_http3_early_data_by_replay_safety` test and the CI `http3` gate in the current rustls/quinn integration. This is a deliberate design decision and should not be flagged as a bug until the runtime/session policy is updated to support that configuration.
Applied to files:
scripts/run-http3-gate.sh
🔇 Additional comments (1)
README.md (1)
78-97: 所有 README 引用的脚本均已提交仓库，无需修改。验证结果确认：
scripts/uninstall.sh、scripts/run-fuzz-coverage.sh、scripts/run-modularization-gate.py及其他脚本均已存在scripts/install.sh支持--mode source、--mode release等所有文档列出的模式scripts/run-fuzz-coverage.sh支持--target参数README 中的脚本调用示例不存在"文档承诺、脚本不存在"的问题。
|
Addressed the README review note in |
vansour
dismissed
coderabbitai[bot]’s stale review
Addressed in bf8b8c6 by documenting rginx peers and rginx upstreams --window-secs 60; the remaining CodeRabbit failure is a review rate-limit issue, not an unresolved code problem.
Summary
run-http3-phase0.shentrypointVerification
bash -n scripts/run-http3-gate.sh scripts/run-http3-release-gate.sh scripts/install.sh scripts/prepare-release.shpython3 scripts/run-modularization-gate.pygit diff --check