Skip to content

Feature/remove hardcoded email addresses#330

Merged
frankcorneliusmartin merged 3 commits intodev3from
feature/remove-hardcoded-email-addresses
Nov 1, 2022
Merged

Feature/remove hardcoded email addresses#330
frankcorneliusmartin merged 3 commits intodev3from
feature/remove-hardcoded-email-addresses

Conversation

@bartvanb
Copy link
Copy Markdown
Member

Fix #319

To repeat question in issue: @frankcorneliusmartin I don't see why you added /token/user in the description of this issue, can you clarify?

@frankcorneliusmartin
Copy link
Copy Markdown
Contributor

Fix #319

To repeat question in issue: @frankcorneliusmartin I don't see why you added /token/user in the description of this issue, can you clarify?

See issue. tl;dr: I dont know

@bartvanb bartvanb changed the base branch from main to dev3 October 10, 2022 13:54
Copy link
Copy Markdown
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good however I am not completely sure if the smtp email is also the email you want to use for support in all cases?

Copy link
Copy Markdown
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Copy Markdown
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frankcorneliusmartin frankcorneliusmartin merged commit 30b8897 into dev3 Nov 1, 2022
@frankcorneliusmartin frankcorneliusmartin deleted the feature/remove-hardcoded-email-addresses branch November 1, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Hard coded email adresses

2 participants