Pitch: Type-Safe Input - #92
Merged
Merged
Conversation
tanner0101
reviewed
Mar 15, 2019
… and top requirement
… Option struct properties
…Runnable can have an associatedtype Signature I know this uses a lot of type-erasure. I will probably try to re-implement the structure of how commands work, but that is not the priority
…nature properties
…use AnyOption and AnyArgument types as arguments
… CommandRunnable protocol
tanner0101
requested changes
Apr 3, 2019
tanner0101
left a comment
tanner0101
left a comment
Member
There was a problem hiding this comment.
Really nice work on this! Overall it looks great, just a couple of ideas for improvement.
…Exactly test case
tanner0101
reviewed
Apr 12, 2019
tanner0101
left a comment
tanner0101
left a comment
Member
There was a problem hiding this comment.
Just one last comment, the rest LGTM. Let's merge it and give it a try :)
|
Hey @calebkleveter, you just merged a pull request, have a coin! You now have 475 coins. |
This was referenced Apr 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
Fixes #91
See the form pitch