Automatically check server version for proper schema generation strategy #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENTITY COLUMN generation
tanner0101
reviewed
Mar 7, 2018
| /// dirty workaround for missing pre migration hook | ||
| public final class PostgreSQLVersionCheckProvider: Provider { | ||
| /// See `Provider.repositoryName` | ||
| public static let repositoryName = "fluent-postgresql-versioncheck" |
There was a problem hiding this comment.
this should be fluent-postgresql (name of the gh repo)
There was a problem hiding this comment.
Done.
I didn't know why this used, I thougt some directory identifier.
tanner0101
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FluentPostgreSQLProvider now automatically checking the server version and if it less than 10 it is disabling the IDENTITY COLUMN generation.