Proposal: #if(string) to not render if string is blank

[bygri]

This is something of a matter of opinion.

Currently, if a Node represents a blank string, using that node as the argument to #if will cause the block to render. I believe that #if should consider a blank string to be equivalent to false, in this case, and therefore not render.

In Polymorphic a bool has three states: true, false or nil, and "" becomes nil, which makes sense. In this tag, "" is considered not-nil and so returns true, rendering the block.

This patch and test causes #if("") to not render its block.

The alternative, and it's also a valid one, is to force the user of the #if tag to convert empty strings to false or nil before rendering.

[codecov-io]

Current coverage is 99.19% (diff: 100%)

Merging #36 into master will increase coverage by 0.01%

@@             master        #36   diff @@
==========================================
  Files            50         50          
  Lines          1352       1369    +17   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1341       1358    +17   
  Misses           11         11          
  Partials          0          0          

Powered by Codecov. Last update 7d0433b...b7c98bb

[tanner0101]

This looks great, thanks!