Fix/fix 52 ‘#export()'depends on ‘{‘ location#65
Hidden character warning
Conversation
| } | ||
|
|
||
| // Move through any redundant whitespace | ||
| while current?.isWhitespace == true && next?.isWhitespace == true { |
There was a problem hiding this comment.
I believe there is a function on this object called skipWhitespace() if it exists, might be good to use that if behavior is same same.
There was a problem hiding this comment.
Hi Logan, Thanks, I didn't see the method for this. It seems to be used in the buffer class in ParameterParser but using some functions from StaticDataBuffer, and will need a pretty solid refactor since it's not available. There is quite a lot of function calls going on in there - while I was trying to understand it right just now you merged the PR, so I think the simple conditional is ok?
| import XCTest | ||
| @testable import Leaf | ||
|
|
||
| class BodyWhitespaceTests: XCTestCase { |
There was a problem hiding this comment.
We'll need to add these to Tests/LinuxMain.swift so they run properly, look at the pattern in that file for other tests and you should be a-ok.
|
@plummer looks great to me, thanks so much for putting this together! A couple of small tweaks, mostly getting the tests running on Linux and we'll merge this. Thanks 👍 |
2 participants
All tests passing.
Please let me know any feedback or if I've totally missed the mark on this one. Thanks.
#52