Skip to content

Swift NIO updates #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tanner0101 merged 1 commit into from
Mar 11, 2019
Merged

Swift NIO updates #13

tanner0101 merged 1 commit into from
Mar 11, 2019

Conversation

@tbartelmess
Copy link
Contributor

@tbartelmess tbartelmess commented Mar 9, 2019

Two tweaks to allow nio-postgres to build against the latest version of Swift-NIO.

  • The signature for encode() in MessageToByteEncoder changed.
  • The encoder also needs to be wrapped into a MessageToByteHandler

@calebkleveter calebkleveter requested a review from tanner0101 March 9, 2019 16:09
tanner0101
tanner0101 approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@tanner0101 tanner0101 added the enhancement New feature or request label Mar 11, 2019
@penny-coin
Copy link

penny-coin commented Mar 11, 2019

Hey @tbartelmess, you just merged a pull request, have a coin!

You now have 2 coins.

@tanner0101 tanner0101 merged commit 9dcb2e7 into vapor:master Mar 11, 2019
@tbartelmess tbartelmess deleted the swift-nio-updates branch March 25, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbartelmess @penny-coin @tanner0101