fix(tests): tolerate .abbreviated formatter "3m ago" output#71
Merged
variablefate merged 1 commit intomainfrom Apr 28, 2026
Merged
fix(tests): tolerate .abbreviated formatter "3m ago" output#71variablefate merged 1 commit intomainfrom
.abbreviated formatter "3m ago" output#71variablefate merged 1 commit intomainfrom
Conversation
`RelativeDateTimeFormatter` with `.abbreviated` and an injected en_US locale produces either "3 min. ago" or "3m ago" depending on the runner process's CFLocale/ICU resource state. Fresh simulator clones spawned by parallel `xcodebuild test` consistently produce the narrower form, which made `lastLocationTimestampLabelIsRelativeString` flake under parallel load while passing in isolation. Accept either form rather than pinning a wider style — `.abbreviated` output is intentional UX for the production label. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
variablefate
added a commit
that referenced
this pull request
Apr 29, 2026
Bumps CURRENT_PROJECT_VERSION from 1 to 2 across all 8 build configurations in project.pbxproj. Build 1 was the live 1.0 build uploaded 2026-04-16 20:25 PT; build 2 is the 1.0.1 candidate shipping the merged work since (#66, #69, #71, #76, #84, #85, #86). Per RELEASING.md, tag will land after App Store Connect confirms upload acceptance, not before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoadFlareTests/PresentationTypesTests/lastLocationTimestampLabelIsRelativeStringflakes under parallelxcodebuild testbut passes in isolation. Production code usesRelativeDateTimeFormatterwithunitsStyle = .abbreviatedand an injecteden_USlocale — that combination produces either "3 min. ago" or "3m ago" depending on the runner process's CFLocale/ICU resource state. Fresh simulator "Clone N" processes spawned for parallel testing consistently produce the narrower "3m ago" form, which the previouslabel.contains("min")assertion rejected.The hypothesis that another test was mutating shared locale state turned out not to be the cause —
RelativeDateTimeFormatter.UnitsStylehas no.narrowmember, no test mutates global locale, and a single-process concurrent stress test on macOS Foundation produces "3m ago" 200/200 deterministically. The variance is process-level resource initialization, not state mutation.Production behavior is intentional (
.abbreviatedis the right UX for that label), so the fix tightens only the test assertion to accept either output:Test plan
main— full parallel suite fails with(label → "3m ago").contains("min")on first attemptxcodebuild test(200 unit tests) — target test passes after fixxcodebuild test -only-testing:RoadFlareTests/DriverDetailViewState— passes-skip-testing:RoadFlareUITests) — passesgitnexus_detect_changes— risk: low, 0 affected processesNotes
While reproducing, I observed 4 unrelated pre-existing failures in
ChatCoordinatorTests,RideCoordinatorTests, and aRoadFlareUITests-Runneraccessibility-load timeout that did not recur on subsequent runs. Those look like separate async-timing flakes worth tracking but are out of scope for this PR.🤖 Generated with Claude Code