ObjectData function not thread safe

[Florian-BACHO]

The following code demonstrate that the ObjectData function is not thread safe and throws std::runtime_error exception.

#include <thread>
#include <ipfs/client.h>

int main()
{
        auto hash = "QmcXneAawME7d3vmV3x95p3WVxczeTid7LpJW8DcH4sA5c";
        ipfs::Client ipfs("localhost", 5001);
        std::thread t1([&hash, &ipfs]() { std::string data; ipfs.ObjectData(hash, &data); });
        std::thread t2([&hash, &ipfs]() { std::string data; ipfs.ObjectData(hash, &data); });

        t1.join();
        t2.join();
        return (0);
}

On MacOS:
libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: Failed initialization

[vasild]

Hi,

You are using the same ipfs::Client object concurrently from two different threads without providing any synchronization. That is not supported. You would get similar result with e.g.:

        std::string s("abcd");
        std::thread t1([&s]() { s.append("x"); });
        std::thread t2([&s]() { s.append("y"); });

Closing as not a bug.

[melroy89]

@Florian-BACHO I don't know if you are still using IPFS and/or C++ IPFS HTTP Client.

But I made some changes under the hood. Allowing to execute the calls within a thread, including terminating the request prematurely and therefor stop the thread.

See the example file.

This example is also part of the examples page on Doxygen.

Part of PR: #57