Skip to content

Add basic support for keys#16

Merged
vasild merged 4 commits intovasild:masterfrom
linas:support-keys
Oct 27, 2019
Merged

Add basic support for keys#16
vasild merged 4 commits intovasild:masterfrom
linas:support-keys

Conversation

@linas
Copy link
Copy Markdown
Contributor

@linas linas commented Oct 19, 2019

Add minimal support for keys; this is needed for IPNS support.

@linas linas mentioned this pull request Oct 19, 2019
@linas
Copy link
Copy Markdown
Contributor Author

linas commented Oct 19, 2019

BTW, You may dislike the API I added: I wanted to have optional parameters with default values, and for that, I had to place them last, after the return value. This is obviously ugly. Another alternative would be to pass in a json holding everything as a single input, but this also seems .. pointlessly ugly. Beats me, Suggest something better, I'll code it up.

@vasild vasild merged commit 0708ec0 into vasild:master Oct 27, 2019
@vasild
Copy link
Copy Markdown
Owner

vasild commented Oct 27, 2019

Hi,

I removed the optional-ness from key_type and key_size and also changed the type of the latter from std::string to size_t. See commits 80b1fb7 and 87a6cce.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants