Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…gy contributions Adds a looksLikeCollection helper that matches titles containing keywords like "omnibus", "box set", "anthology", "complete", "collected", etc., and wires it into hardFilter so these multi-work entries are suppressed from the Discover page. Includes TestLooksLikeCollection covering 8 cases. Closes #361 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vavallee
force-pushed
the
fix/recommender-collection-filter
branch
from
4bccb92 to
2c92633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
looksLikeCollection(title string) booltointernal/recommender/candidates.go; returns true when the title (case-insensitive) contains any of:complete,collected,omnibus,boxed set,box set,anthology,the best of,stories of,tales of,(omnibus),(collection),complete works,complete collectionhardFilterininternal/recommender/recommender.goso matching candidates are suppressed from the Discover pageTestLooksLikeCollectionincandidates_test.gocovering 8 cases (7 matches, 1 clean title)Closes #361
Test plan
go test ./internal/recommender/...passes🤖 Generated with Claude Code