Skip to content

fix(abs): improve review search matching#599

Merged
vavallee merged 3 commits into
vavallee:mainfrom
magrhino:codex/abs-review-search-ux
May 12, 2026
Merged

fix(abs): improve review search matching#599
vavallee merged 3 commits into
vavallee:mainfrom
magrhino:codex/abs-review-search-ux

Conversation

@magrhino
Copy link
Copy Markdown
Contributor

@magrhino magrhino commented May 12, 2026

Summary

  • Show up to 10 scrollable author/book search matches in the ABS no-match review queue.
  • Auto-link the selected book's author before resolving the book when the review item has no resolved author.
  • Add focused ABS review tests and an [Unreleased] changelog entry.

Checklist

  • Tests added or updated
  • docs/DEPLOYMENT.md updated if env vars, config, or upgrade path changed - N/A, no deployment/config surface changed
  • CHANGELOG.md [Unreleased] section updated
  • Wiki pages updated if user-facing behaviour changed - N/A for this narrow review-queue fix

Test plan

  • git diff --check upstream/main...HEAD
  • gofmt -l .
  • npm test -- SettingsPage.absReview.test.tsx
  • npm ci
  • npm run lint (passes with existing warnings)
  • npm run typecheck
  • npm run build
  • GOTOOLCHAIN=go1.25.10 GOCACHE=<tmp>/bindery-gocache go vet ./...
  • GOTOOLCHAIN=go1.25.10 GOCACHE=<tmp>/bindery-gocache GOLANGCI_LINT_CACHE=<tmp>/bindery-golangci-cache <tmp>/bindery-bin/golangci-lint run --timeout=5m
  • GOTOOLCHAIN=go1.25.10 GOCACHE=<tmp>/bindery-gocache <tmp>/bindery-bin/govulncheck ./...
  • GOTOOLCHAIN=go1.25.10 GOCACHE=<tmp>/bindery-gocache go test ./cmd/... ./internal/...

@magrhino magrhino force-pushed the codex/abs-review-search-ux branch from 7e44282 to 7b6f973 Compare May 12, 2026 00:21
@magrhino magrhino marked this pull request as ready for review May 12, 2026 00:25
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vavallee vavallee merged commit 5d48c5b into vavallee:main May 12, 2026
29 checks passed
vavallee added a commit that referenced this pull request May 12, 2026
Critical user-reported fixes:
- #594 backup creation crashes Settings page (regression from v1.9.0)
- #562 Hardcover list sync GraphQL query (broken since v1.1.0)
- #560 proxy auth /auth/status bypass (proxy mode totally non-functional)
- #531 NZBGet Prowlarr-proxy empty NZB (apikey not signed on download URLs)
- #563 author matching token-overlap false positives
- #596 Hardcover enhanced series default on
- #599 ABS review search UX
- #592/#543 queue timestamps

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants