Skip to content

Add py.typed file to mark package as type-annotated, merge into pyproject.toml#57

Merged
vb64 merged 6 commits intovb64:typedfrom
parker-research:typing
Apr 14, 2025
Merged

Add py.typed file to mark package as type-annotated, merge into pyproject.toml#57
vb64 merged 6 commits intovb64:typedfrom
parker-research:typing

Conversation

@parker-research
Copy link
Copy Markdown
Contributor

See commits for individual descriptions of each change.

This fixes #31, albeit in a slightly different way than requested in that project.

@vb64
Copy link
Copy Markdown
Owner

vb64 commented Apr 8, 2025

Please restore the build/.gitignore file.

It is necessary to avoid creating the build directory when running test suite.

@parker-research
Copy link
Copy Markdown
Contributor Author

Why isn't including build/ in the root .gitignore file adequate? That's by far the standard way to do that...

@vb64
Copy link
Copy Markdown
Owner

vb64 commented Apr 9, 2025

Ok.

But now we need to solve the problem with failed tests under Python 3.8

@parker-research
Copy link
Copy Markdown
Contributor Author

Can you just drop Python 3.8 support? Seems like it requires hacks/workarounds, and it's pretty well out of use now.

Python3.8 is an unsupported version, and no longer even receives security updates: https://devguide.python.org/versions/

If not, I'll look at fixing it though. Am curious why it fails

@vb64
Copy link
Copy Markdown
Owner

vb64 commented Apr 9, 2025

No.

3.8 is the latest version of Python that runs on Windows 7. It is a must for those people and organizations that initiated the creation of this module.

@parker-research
Copy link
Copy Markdown
Contributor Author

Maintaining support for Windows 7 (which has been past EOL for 2 years now) is a hilarious reason to maintain backwards compatibility. People using Windows 7 certainly shouldn't be expecting up-to-date dependencies - I certainly wouldn't even try to upgrade if I was in that boat.

@parker-research
Copy link
Copy Markdown
Contributor Author

Anyway, pretty sure it was a trivial fix there. Would be nice if workflows ran automatically on PRs - would you mind retriggering the tests (which seem to pass locally for me)?

@vb64 vb64 changed the base branch from main to typed April 14, 2025 05:40
@vb64 vb64 merged commit 5fb9cdd into vb64:typed Apr 14, 2025
8 checks passed
vb64 added a commit that referenced this pull request Apr 14, 2025
…oject.toml` (#58)

* Add `py.typed` file to mark package as type-annotated, merge into `pyproject.toml` (#57)

* Fix `borders` type hint

* Clean up `.gitignore`

* Merge dependencies and setup.cfg into Pyproject.toml

* Repair Makefile and GHAs (`requirements -> pyproject.toml`)

* Fix bad Python3.8 type hint

* Fix package build.

* update history.txt

* restore build/.gitignore file

* cosmetic

---------

Co-authored-by: Parker L <166864283+parker-research@users.noreply.github.com>
@parker-research
Copy link
Copy Markdown
Contributor Author

Is this in the latest release? I'm still getting the error in Pyright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Add stubs file and type checking

2 participants