Add py.typed file to mark package as type-annotated, merge into pyproject.toml#57
Add py.typed file to mark package as type-annotated, merge into pyproject.toml#57vb64 merged 6 commits intovb64:typedfrom
py.typed file to mark package as type-annotated, merge into pyproject.toml#57Conversation
|
Please restore the It is necessary to avoid creating the |
|
Why isn't including |
|
Ok. But now we need to solve the problem with failed tests under Python 3.8 |
|
Can you just drop Python 3.8 support? Seems like it requires hacks/workarounds, and it's pretty well out of use now. Python3.8 is an unsupported version, and no longer even receives security updates: https://devguide.python.org/versions/ If not, I'll look at fixing it though. Am curious why it fails |
|
No. 3.8 is the latest version of Python that runs on Windows 7. It is a must for those people and organizations that initiated the creation of this module. |
|
Maintaining support for Windows 7 (which has been past EOL for 2 years now) is a hilarious reason to maintain backwards compatibility. People using Windows 7 certainly shouldn't be expecting up-to-date dependencies - I certainly wouldn't even try to upgrade if I was in that boat. |
|
Anyway, pretty sure it was a trivial fix there. Would be nice if workflows ran automatically on PRs - would you mind retriggering the tests (which seem to pass locally for me)? |
…oject.toml` (#58) * Add `py.typed` file to mark package as type-annotated, merge into `pyproject.toml` (#57) * Fix `borders` type hint * Clean up `.gitignore` * Merge dependencies and setup.cfg into Pyproject.toml * Repair Makefile and GHAs (`requirements -> pyproject.toml`) * Fix bad Python3.8 type hint * Fix package build. * update history.txt * restore build/.gitignore file * cosmetic --------- Co-authored-by: Parker L <166864283+parker-research@users.noreply.github.com>
|
Is this in the latest release? I'm still getting the error in Pyright |
See commits for individual descriptions of each change.
This fixes #31, albeit in a slightly different way than requested in that project.