Skip to content

.travis.yml: Add '-set_exit_status' to golint invocation #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2017
Merged

.travis.yml: Add '-set_exit_status' to golint invocation #28

merged 2 commits into from
Apr 27, 2017

Conversation

@wking
Copy link
Contributor

@wking wking commented Apr 27, 2017 •
edited
Loading

So Travis tells us when golint finds something suspicious.

Fixes #26.
Fixes #27.

@wking
.travis.yml: Add '-set_exit_status' to golint invocation
b4e2a47 
So Travis tells us when golint finds something suspicious.

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking mentioned this pull request Apr 27, 2017
Closed
@vbatts
Copy link
Owner

vbatts commented Apr 27, 2017

#27 will also be needed before this. likely. And actively trying to get to the bottom of #24 :-\

@wking
Copy link
Contributor Author

wking commented Apr 27, 2017 via email

@wking
Copy link
Contributor Author

wking commented Apr 27, 2017

Oops, flipped those around. I'll work on #27 but am not affected by #24.

@wking
rules/danglingwhitespace/rule.go: Comment for ValidateDanglingWhitespace
094999a 
Avoid golint's:

  rules/danglingwhitespace/rule.go:22:1: exported function ValidateDanglingWhitespace should have comment or be unexported

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking
Copy link
Contributor Author

wking commented Apr 27, 2017

I've pushed b4e2a47 → 094999a to fix #27 too.

@vbatts
Copy link
Owner

vbatts commented Apr 27, 2017

LGTM

@vbatts vbatts merged commit 5a672d8 into vbatts:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wking @vbatts