travis: only run the git-validation on pull-requests #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Apr 27, 2017
.travis.yml
Outdated
| - go build . | ||
| - go test -v ./... | ||
| - ./git-validation -run DCO,short-subject,dangling-whitespace -v | ||
| - 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then ./git-validation -run DCO,short-subject,dangling-whitespace -v ; fi' |
Contributor
There was a problem hiding this comment.
I think a better fix would be to build this logic into git-validation. If it can't handle non-PR tests, we don't want to have to copy this guard into every consuming project's invocation.
vbatts
force-pushed
the
fix_push_ci
branch
2 times, most recently
from
2c39d64 to
13aeff1
Compare
Fixes #24 https://docs.travis-ci.com/user/pull-requests/ Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
wking
reviewed
Apr 27, 2017
|
|
||
| before_script: | ||
| - env | ||
| - echo $TRAVIS_COMMIT_RANGE |
Contributor
There was a problem hiding this comment.
With the env (which I approve of), you can drop all the following echo $TRAVIS_… lines.
Owner
Author
|
this will silently cause the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
https://docs.travis-ci.com/user/pull-requests/
Signed-off-by: Vincent Batts vbatts@hashbangbash.com