Consider only commit IDs when listing range #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `git log`, if some/all commits are gpg-signed, git will automatically try to validate the signatures by default. This results in printing additional text. This additional gpg-validation text is then incorrectly interpreted by `git-validate` as if they were commit IDs. Fix the problem by using the `rev-list` sub-command which will ONLY list the IDs. Signed-off-by: Chris Evich <cevich@redhat.com>
vbatts
approved these changes
Sep 16, 2020
Owner
vbatts
left a comment
vbatts
left a comment
There was a problem hiding this comment.
largely LGTM.
comparing the output of these two commands locally looks like there is a final newline, but I don't think that'll be an issue. Let's find out ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
When using
git log, if some/all commits are gpg-signed, git willautomatically try to validate the signatures by default. This results
in printing additional text. This additional gpg-validation text is
then incorrectly interpreted by
git-validateas if they were commitIDs. Fix the problem by using the
rev-listsub-command which willONLY list the IDs.
Signed-off-by: Chris Evich cevich@redhat.com