[LOCKLITE-112 & LOCKLITE-131] Create login page#69
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates a login page and reorganizes the application structure by splitting UI and API routes. The main purpose is to establish proper authentication flow with a dedicated login page under the /ui route structure.
Key changes:
- Created a new login page at
/ui/loginwith proper authentication flow - Refactored PageContainer component to accept a title prop for consistent page layout
- Reorganized import paths to reflect the new UI structure and component organization
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/ui/router/routes.enum.ts | Defines route constants for UI paths including login, workspace, and homepage |
| src/modules/ui/components/auth/molecules/SignInForm.tsx | New sign-in form component with proper session handling and error management |
| src/modules/shared/auth/session-status.enum.ts | Enum for NextAuth session status constants |
| src/modules/ui/components/common/PageContainer.tsx | Enhanced to accept title prop and provide consistent page layout |
| src/app/ui/login/page.tsx | New login page component using the refactored SignInForm |
| src/lib/auth.ts | Updated to use route enum constants for sign-in/sign-out pages |
| src/app/ui/page.tsx | Updated to redirect to login instead of workspace |
| src/app/ui/workspace/page.tsx | Refactored to use new PageContainer with title prop |
| src/modules/ui/components/vaults/organisms/DynamicVaultsList.tsx | Updated import paths to reflect new component organization |
| src/app/login/page.tsx | Removed old login page implementation |
| src/app/login/layout.tsx | Removed old login layout |
| src/app/ui/workspace/layout.tsx | Removed unnecessary workspace layout |
vbetsch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split UI and API routes