[LOCKLITE-115] Create an Auth Guard in UI#75
Merged
Conversation
vbetsch
added
ui
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates an authentication guard system for the UI to control access to protected pages. The main purpose is to implement route-based authentication where certain pages require users to be logged in.
- Introduces an
AuthGuardcomponent that redirects unauthenticated users to sign in - Refactors layout structure by extracting
PageLayoutfromClientProvidersfor better separation of concerns - Updates import paths for
PageContainercomponent that was moved to the templates directory
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/ui/guards/AuthGuard.tsx | New auth guard component that checks session status and handles authentication |
| src/app/ui/workspace/layout.tsx | New workspace layout that wraps children with the AuthGuard |
| src/modules/ui/components/templates/PageLayout.tsx | Extracted layout component containing MainNavBar and Container |
| src/modules/ui/providers/ClientProviders.tsx | Simplified to only provide theme and session context |
| src/app/ui/layout.tsx | Updated to use the new PageLayout component |
| src/modules/ui/components/auth/molecules/SignInForm.tsx | Enhanced error handling to check URL search params for authentication errors |
| src/modules/ui/components/navigation/organisms/MainNavBar.tsx | Updated to use SessionStatus enum instead of string literal |
| src/app/ui/login/page.tsx | Removed redundant SessionProvider wrapper |
| src/app/ui/workspace/page.tsx | Updated import path for PageContainer |
| tests/units/modules/ui/components/common/PageContainer.test.tsx | Updated import path for PageContainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.