Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements user-specific vault filtering to ensure users can only see their own vaults. The implementation adds a new service to handle current user retrieval and updates the vault repository to filter by user ID.
- Refactors vault retrieval to filter by current user ID instead of returning all vaults
- Extracts common current user logic into a reusable service
- Updates repository method to accept user ID parameter for filtering
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/api/infra/repositories/vaults.repository.ts | Changes findAll() to findByUserId() with user filtering |
| src/modules/api/infra/records/vaults/vault-user-id.record.ts | Adds type definition for vault user ID record |
| src/modules/api/domain/usecases/vaults/get-my-vaults.usecase.ts | Updates to use current user service and filtered vault retrieval |
| src/modules/api/domain/usecases/vaults/create-vault.usecase.ts | Refactors to use new current user service instead of inline implementation |
| src/modules/api/domain/services/current-user.service.ts | Creates new service to handle current user retrieval logic |
src/modules/api/domain/usecases/vaults/get-my-vaults.usecase.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.