[Feat] psf rgbd conv disparity interpolation#100
Merged
singer-yang merged 2 commits intomainfrom Feb 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for both depth and disparity interpolation modes in PSF-based image rendering, improves the flexibility and accuracy of RGBD rendering, and adds comprehensive tests and documentation for these enhancements. The main changes include updating the rendering functions to accept an
interp_modeargument, refactoring the convolution logic for efficiency, and expanding test coverage to ensure correct behavior for edge cases and new features.Rendering and Interpolation Enhancements
interp_modeargument ("depth" or "disparity") to therender_rgbdmethod and underlying PSF convolution functions (conv_psf_depth_interp,conv_psf_map_depth_interp), allowing users to choose interpolation in either depth or disparity space for more accurate image simulation. [1] [2] [3] [4]conv_psf_depth_interpto use grouped convolutions for improved efficiency and maintainability, and ensured correct padding and kernel handling.API and Usage Improvements
render_rgbdmethod signature and documentation to clarify input requirements and new options, and improved error handling for invalid depth values and interpolation modes. [1] [2]Testing
conv_psf_map_depth_interpfunction.Miscellaneous
test/README.mdfor clarity and completeness.These changes collectively improve the flexibility, reliability, and usability of the PSF-based rendering pipeline for RGBD images.