-
Notifications
You must be signed in to change notification settings - Fork 3
Added initial version of CI to rebuild dependencies package #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
709cdd5 to
218a103
Compare
|
isn't it possible to setup GhA to run a pipeline when specific file(s) in repo change? In such cases changes to conanfile.py (and Conan profiles) in VCMI repo should run the "build missing dependencies" pipeline. |
|
Detecting changes in conanfile looks like possible but only with some assistance - third-party actions step or similar implementation by us, via git commands. And at least one of the problems with unified workflow is that prebuilts packages are download via fixed url, e.g. So it can't be a separate pipeline (even with dependencies) - since even if we were to generate new package and create release with it, our main pipeline would still download old dependencies package since this is where URL in checked out code points to. We also can't use URL to 'latest' release since newer package may not work with older vcmi. Like this ffmpeg update that requires to fix 1 deprecation to work with vcmi. Currently we require following steps:
No idea how to fit all of that into a single workflow, especially one that would work with parallel development / branches. |
|
true, and that's where Artifactory would come to play... However, it should still be solvable via a parameter that will be passed to the downstream (VCMI build) job. |
|
btw XZ provides better compression, I'd keep using it instead of GZ |
Maybe, but not sure how to implement such approach.
Sure, can change. My intention was to unify compression method - mingw used gz, macos used xz. Can switch to xz everywhere. |
|
another thought on the workflow:
extra branches (e.g. develop) can be created in this repo as needed. still, Artifactory would be the ideal solution. We should ask some other service for a free server :) JFrog seemed to ignore my request. |
978f929 to
d0febae
Compare
|
Thanks for suggestions, haven't considered submodules for CI files. Will add docs (including these suggestions in TODO list) in a separate PR tomorrow. |
Continuation of vcmi/vcmi#4461
Trying to establish flow for update of conan-built dependencies (so all other than msvc which uses vcpkg).
Currently planning following flow:
Not sure about 1st step. We need new version of conanfile as well as few files from vcmi/vcmi repo, however it feels weird to create branch that would only be used in another repo. But haven't found better approaches.
TODO's for future: