Restrict builtins in AssertionEvaluator eval fallback path#12
Closed
Copilot wants to merge 2 commits intocodemode_driven_generationfrom
Closed
Restrict builtins in AssertionEvaluator eval fallback path#12Copilot wants to merge 2 commits intocodemode_driven_generationfrom
Copilot wants to merge 2 commits intocodemode_driven_generationfrom
Conversation
Co-authored-by: fswair <62549656+fswair@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on builtins restriction for eval fallback
Restrict builtins in AssertionEvaluator eval fallback path
Mar 19, 2026
Copilot stopped work on behalf of
fswair due to an error
March 19, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AssertionEvaluatorfallbackevalpassedinputsdirectly as globals/locals, leaving__builtins__unrestricted and reintroducing arbitrary code execution that the restricted-builtins model was meant to prevent.Changes
eval(self.condition, inputs, inputs)with a restricted env usingSAFE_ASSERTION_BUILTINS, matching the primary_eval_assertion_restrictedpath__builtins__override prevention: both primary and fallback paths now use{**inputs, "__builtins__": SAFE_ASSERTION_BUILTINS}so a caller-controlledinputskey cannot shadow the restrictionpowadded toSAFE_ASSERTION_BUILTINS: safe math builtin previously only reachable via the unrestricted fallback; making it explicit maintains backward compatibility💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.