Summer cleanup#40
Merged
Merged
Conversation
- Use try/except for non-zero return codes in Base.run, util.run - This and earlier commits, assure signature and return of Base.run, util.run is the same - Remove add dummy file in svn test - Don't stream_stderr by default, most run calls didn't use it, so make it opt-in - Don't log_stdout by default, most run calls didn't use it, same as above
Improve get_revision behavior to handle initial repos Add Base.run_buffered which buffers straight to stdout, for functions where we don't want to record stdout, such as git pull, hg/git clone, etc. Only front-end cli usage cares about buffering to stdout. todo: for API only usage such as https://github.com/jcfr/pys4ext it should be quiet. Base.run is for directly checking output responses
Logging/running commands can be very ambiguous/confusing. Lets keep things clear as possible while working on this, we can relax the length of kwarg variable name print_stdout_on_progress_end before release.
Current coverage is 67.67%@@ master #40 diff @@
==========================================
Files 9 9
Lines 755 727 -28
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 509 492 -17
+ Misses 246 235 -11
Partials 0 0
|
The long method name is temporary. Currently, the url attribute on VCS classes is the pip-style url and not the raw URL a repo would use. This leads to confusion and ambiguity since the pip-url is really only important from a front-end perspective. After the true url and rev is resolved, there is no need for it in the instance.
Also rename class variable name to bin_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big clean up of unused functionality, functions, documentation.
Consolidation of
Base.runmethod,util.runfunctions as well as docs to make the behavior (hopefully) more clear and consistent.New
Base.run_bufferedto make it clear a subprocess will pass-thru buffered output as a normal CLI command would.