Phase 5: Sidecars & Cleanup Implementation#18
Merged
vdemeester merged 3 commits intomainfrom Feb 6, 2026
Merged
Conversation
- Add sidecar.go with pod operations (CreatePod, StartPod, StopPod, RemovePod) - Implement StartSidecar and StopSidecar methods - Add CreateContainerInPod for running containers inside pods - Make container command optional (use image default entrypoint) - Add comprehensive tests for sidecar lifecycle TDD approach: tests written first, then implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ResourceTracker for tracking containers, pods, and volumes - Thread-safe tracking with mutex protection - CleanupAll removes all tracked resources - Uses fresh context with timeout for cleanup (handles canceled contexts) - Add RemoveVolume function for volume cleanup TDD approach: tests written first, then implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Sidecar Support (~285 LOC)
sidecar.gowith pod operations:CreatePod,StartPod,StopPod,RemovePodCreateContainerInPodfor running containers inside podsStartSidecarandStopSidecarmethodsResource Cleanup (~150 LOC)
cleanup.gowithResourceTracker:CleanupAllremoves all tracked resourcesRemoveVolumefunctionContainer Spec Changes
ContainerSpec.Validate()Test plan
🤖 Generated with Claude Code