fix: replace if+TrimSuffix with unconditional TrimSuffix (staticcheck S1017)#28
Merged
vdemeester merged 1 commit intomainfrom Feb 23, 2026
Merged
fix: replace if+TrimSuffix with unconditional TrimSuffix (staticcheck S1017)#28vdemeester merged 1 commit intomainfrom
vdemeester merged 1 commit intomainfrom
Conversation
… S1017) Use strings.TrimSuffix unconditionally instead of guarding it with strings.HasSuffix, as TrimSuffix is already a no-op when the suffix is not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI lint failure on
main.Problem:
staticcheckS1017 flags the pattern of checkingstrings.HasSuffixbefore callingstrings.TrimSuffix, sinceTrimSuffixis already a no-op when the suffix isn't present.Fix: Replace the guarded
if strings.HasSuffix(...) { ... = strings.TrimSuffix(...) }with a directstrings.TrimSuffix(...)call.File:
pkg/parser/parser.go:598