Skip to content

Add Ethereum Nonce Handling#1612

Closed
otherview wants to merge 14 commits into
eth-equivalencefrom
pedro/eth_eq_nonce
Closed

Add Ethereum Nonce Handling#1612
otherview wants to merge 14 commits into
eth-equivalencefrom
pedro/eth_eq_nonce

Conversation

@otherview
Copy link
Copy Markdown
Member

Description

Adds Nonce handling for tracking TypeEthTyped1559 Tx's

To keep this simple used the rlp:"tail" to decode optional empty fields - we might use a proper rlp:"optional" but that will require updating the vendored deps.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@otherview otherview requested a review from a team as a code owner May 5, 2026 08:27
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
runtime/statedb/statedb.go 62.50% 6 Missing ⚠️
runtime/runtime.go 55.55% 2 Missing and 2 partials ⚠️
state/state.go 76.47% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@paologalligit paologalligit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but should we put in place a check for trx.Nonce() against rt.state.GetNonce(origin) before execution. Somewhere in runtime.go in PrepareTransaction function after ResolveTransaction(trx) and before BuyGas(...?

Base automatically changed from pedro/eth_equivalence_v2 to eth-equivalence May 8, 2026 10:20
@otherview
Copy link
Copy Markdown
Member Author

Defered to #1616

@otherview otherview closed this May 8, 2026
@otherview otherview deleted the pedro/eth_eq_nonce branch May 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants