chore: Document options naming and remediate#3714
Merged
Conversation
Signed-off-by: James Turnbull <james@lovedthanlost.net>
The `fingerprint_bytes` options becomes `bytes`. Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: James Turnbull <james@lovedthanlost.net>
jamtur01
requested review from
JeanMertz,
MOZGIII and
binarylogic
as code owners
MOZGIII
reviewed
Sep 18, 2020
Signed-off-by: James Turnbull <james@lovedthanlost.net>
MOZGIII
approved these changes
Sep 18, 2020
Contributor
MOZGIII
left a comment
MOZGIII
left a comment
There was a problem hiding this comment.
It's really nice to have some guidelines on naming!
Contributor
|
The name changes look great, I would just like to think about backward compatibility. I assume it would be easy to map the old names to the new names? |
Signed-off-by: James Turnbull <james@lovedthanlost.net>
Contributor
Author
|
@binarylogic I've added aliases to the |
lukesteensen
approved these changes
Oct 2, 2020
Member
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
You've done the aliasing correctly, but we don't necessarily have a good way to surface the deprecation to the user right now. That'd require something a bit fancier to plug into deserialization. I'll make a note to consider this in the config RFC.
Contributor
Author
|
Thanks! |
juchiast
reviewed
Oct 7, 2020
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example changes in this PR:
fingerprint_bytesoption becomesbytes.merge_fieldsoption becomesfields.