add missing LIN experimental docs to html (SILKIT-1738)#197
Merged
Conversation
debug command path
use system libs for mingw-w64 build WORKAROUND
fix build on mingw with system libs
VJanKraemer
requested changes
Apr 15, 2025
Contributor
VJanKraemer
left a comment
VJanKraemer
left a comment
There was a problem hiding this comment.
LAGTM
One C-API function is probably missing and some small stylistic hiccups. Otherwise splendid!
Collaborator
Author
|
@VJanKraemer also deleted the now unused SilKitTestAsio.cmake file |
SimplyLMK
pushed a commit
to SimplyLMK/sil-kit
that referenced
this pull request
Oct 23, 2025
Use system libs for mingw-w64 build (WORKAROUND) and fix build on mingw with system libs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doxygen API docs were missing because the functions were not referenced.
Switch the github CI MinGW build to use system libraries and fix the cmake logic.