config: enable configuration override for publisher history length#226
Merged
VDanielEdwards merged 3 commits intoJul 11, 2025
Merged
Conversation
00c45f6 to
88a6821
Compare
There was a problem hiding this comment.
Pull Request Overview
Enables overriding the publisher history length in the participant configuration, mirroring existing overrides for topic and labels.
- Adds an optional
historyfield toDataPublisherin the participant config - Integrates the override into publisher creation (update, validation, and application)
- Updates YAML reader/writer/validator/schema and adds integration tests
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/CHANGELOG.rst | Document the new history-length override feature |
| SilKit/source/core/participant/Participant_impl.hpp | Apply the history override, validate and set history |
| SilKit/source/config/YamlWriter.cpp | Serialize history field |
| SilKit/source/config/YamlValidator.cpp | Include History in schema paths |
| SilKit/source/config/YamlReader.cpp | Parse history field |
| SilKit/source/config/ParticipantConfiguration.hpp | Add optional history member |
| SilKit/source/config/ParticipantConfiguration.schema.json | Define and reference the History property |
| SilKit/source/config/ParticipantConfiguration_Full.yaml/json | Add sample History entries |
| SilKit/IntegrationTests/ITest_PubHistory.cpp | Add tests covering API and config override behavior |
| SilKit/IntegrationTests/CMakeLists.txt | Include the new test in the integration suite |
Comments suppressed due to low confidence (2)
SilKit/IntegrationTests/ITest_PubHistory.cpp:229
- Consider adding a test for an invalid configuration (e.g. History: 2) to verify that the configuration error is properly thrown or caught.
}
SilKit/IntegrationTests/ITest_PubHistory.cpp:117
- [nitpick] The test name uses 'conf' as shorthand for 'configuration'; consider renaming to 'config' for clarity (e.g. history_api_one_config_empty).
TEST_F(ITest_PubHistory, history_api_one_conf_empty)
Member
Author
|
|
MariusBgm
approved these changes
Jul 9, 2025
SimplyLMK
pushed a commit
to SimplyLMK/sil-kit
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
Makes it possible to override the publisher history length in the participant configuration. Analogous to the override of the topic, or the labels.
JIRA: SILKIT-1777
Developer checklist (address before review)