fix(coding-agents): report and attribute the configured MCP harness (#3342)

The MCP server resolved its harness (HINDSIGHT_MCP_HARNESS, defaulting to
claude-code) for bank resolution but never passed it to buildKnowledgeTools, so
the tools it builds had no idea which agent they were serving.

Two things follow from passing it:

- hindsight_diagnose reports the actual harness instead of 'unknown'.
- hindsight_ingest_document now stamps the harness:<id> tag and metadata.harness.
  Documents ingested through the MCP tool were previously unattributed, and the
  documents list resolves a document's agent logo and filter from exactly those
  fields.

cfg.harness is the right source: loadConfig back-fills the asking harness onto an
unset field (#3247), so it is the launching harness rather than resolveConfig's
'opencode' default.

Co-authored-by: TheAngryPit

Author: TheAngryPit

hindsight-integrations/coding-agents/src/mcp-server.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import { selectTools } from "./mcp-server";
 import { resolveConfig } from "./core/config";
 import type { HindsightClient } from "./core/hindsight";
@@ -29,4 +29,29 @@ describe("selectTools", () => {
       ].sort()
     );
   });
+
+  it("propagates the configured harness to diagnostics", async () => {
+    const cfg = resolveConfig({ harness: "codex" });
+    const tools = selectTools(cfg, stubClient, "b");
+    const diagnose = tools.find((tool) => tool.name === "hindsight_diagnose");
+
+    expect(diagnose).toBeDefined();
+    const result = await diagnose!.handler({});
+    expect(JSON.parse(result.content[0].text)).toMatchObject({ harness: "codex" });
+  });
+
+  it("also attributes documents ingested through the MCP tool to that harness", async () => {
+    // The same option feeds hindsight_ingest_document, which until now stamped nothing: the
+    // documents list resolves a document's agent logo from `metadata.harness` / `harness:<id>`,
+    // so MCP-ingested documents used to show up unattributed.
+    const retain = vi.fn().mockResolvedValue(undefined);
+    const client = { retain } as unknown as HindsightClient;
+    const tools = selectTools(resolveConfig({ harness: "codex" }), client, "b");
+    const ingest = tools.find((tool) => tool.name === "hindsight_ingest_document");
+
+    await ingest!.handler({ title: "Runbook", content: "steps" });
+    const [, , , tags, , opts] = retain.mock.calls[0];
+    expect(tags).toContain("harness:codex");
+    expect(opts.metadata).toMatchObject({ harness: "codex" });
+  });
 });

hindsight-integrations/coding-agents/src/mcp-server.ts

@@ -23,7 +23,9 @@ import { buildKnowledgeTools, type ToolSpec } from "./core/knowledge-tools";
  * connects, it just has nothing registered.
  */
 export function selectTools(cfg: Config, client: HindsightClient, bankId: string): ToolSpec[] {
-  return cfg.disabled ? [] : buildKnowledgeTools(client, bankId, { repoDir: process.cwd() });
+  return cfg.disabled
+    ? []
+    : buildKnowledgeTools(client, bankId, { repoDir: process.cwd(), harness: cfg.harness });
 }
 
 async function main() {