fix(mcp): route update_bank through config resolver, expose all fields#1168
Merged
nicoloboschi merged 1 commit intomainfrom Apr 21, 2026
Merged
fix(mcp): route update_bank through config resolver, expose all fields#1168nicoloboschi merged 1 commit intomainfrom
nicoloboschi merged 1 commit intomainfrom
Conversation
…ig_updates The MCP update_bank tool was writing mission to the legacy DB column instead of the config system, causing silent data loss. Now uses a generic config_updates dict that passes through to config_resolver.update_bank_config(), automatically supporting all current and future configurable fields without MCP tool changes. Closes #1156
nicoloboschi
force-pushed
the
fix/mcp-update-bank-config-fields
branch
from
9021dd3 to
ab3bb6a
Compare
r266-tech
added a commit
to r266-tech/hindsight
that referenced
this pull request
Apr 21, 2026
Follow-up to vectorize-io#1168: update_bank now accepts config_updates with all bank-configurable fields (reflect_mission, retain_*, disposition_*, entity_labels, recall_*, mcp_enabled_tools, etc.). Existing docs only showed name + mission; callers had to read mcp_tools.py to discover the full surface. Mirrored to skills/hindsight-docs/references/developer/mcp-server.md per the dual-doc convention (vectorize-io#1137).
3 tasks
nicoloboschi
pushed a commit
that referenced
this pull request
Apr 21, 2026
#1183) * docs(mcp): document update_bank config_updates and configurable fields Follow-up to #1168: update_bank now accepts config_updates with all bank-configurable fields (reflect_mission, retain_*, disposition_*, entity_labels, recall_*, mcp_enabled_tools, etc.). Existing docs only showed name + mission; callers had to read mcp_tools.py to discover the full surface. Mirrored to skills/hindsight-docs/references/developer/mcp-server.md per the dual-doc convention (#1137). * docs(mcp): mirror update_bank config_updates docs to skills reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_banktool was writingmissionto the legacybanks.missionDB column instead of the config system (reflect_mission), causing the value to be silently ignored whenreflect_missionwas already set in config. The HTTP PATCH endpoint correctly routed through the config resolver — the MCP tool now does the same.reflect_mission,retain_mission,retain_extraction_mode,retain_custom_instructions,retain_chunk_size,enable_observations,observations_mission,disposition_skepticism,disposition_literalism,disposition_empathy.missionparameter is kept and mapped toreflect_mission(matching HTTP PATCH behavior).Closes #1156
Test plan
test_update_bankupdated to verify config resolver routing