Skip to content

fix: allow reflect-specific LLM config when default is disabled#1189

Merged
nicoloboschi merged 1 commit intovectorize-io:mainfrom
zwcf5200:pr/reflect-llm-config
Apr 22, 2026
Merged

fix: allow reflect-specific LLM config when default is disabled#1189
nicoloboschi merged 1 commit intovectorize-io:mainfrom
zwcf5200:pr/reflect-llm-config

Conversation

@zwcf5200
Copy link
Copy Markdown
Contributor

Summary

Allow reflect to use its own configured LLM provider even when the default memory
LLM provider is disabled.

Previously, reflect was blocked when the default LLM provider was none, even if
reflect_llm_provider was configured separately.

Tests

  • uv run ruff check hindsight-api-slim/hindsight_api/engine/memory_engine.py hindsight-api-slim/tests/test_per_operation_llm_config.py
  • uv run pytest hindsight-api-slim/tests/ test_per_operation_llm_config.py::TestReflectUsesReflectLLMConfig -n0

Note: the full test_per_operation_llm_config.py file currently has existing
failures on retry default expectations unrelated to this change.

Copy link
Copy Markdown
Collaborator

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@nicoloboschi nicoloboschi merged commit afd00c0 into vectorize-io:main Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants