fix(test): remove stale profile auto-create assertion from bank stats test#1323
Merged
nicoloboschi merged 4 commits intomainfrom Apr 29, 2026
Merged
fix(test): remove stale profile auto-create assertion from bank stats test#1323nicoloboschi merged 4 commits intomainfrom
nicoloboschi merged 4 commits intomainfrom
Conversation
… test
GET /banks/{bank_id}/profile no longer auto-creates banks (99a8978),
so the empty-bank timeseries test was failing with 404. The profile
check was unnecessary — the timeseries endpoint handles non-existent
banks by returning zero-filled buckets.
Three more tests relied on GET /profile auto-creating banks: - test_base_path: remove redundant profile GET, retain creates the bank - test_http_api_integration: same — bank is created by the first retain - test_bank_templates: export of nonexistent bank now correctly expects 404
More tests relied on GET /profile to auto-create banks: - test_reflections: 6 occurrences used as bank creation step - test_http_api_integration: 1 occurrence used to ensure bank exists - test_base_path_deployment: 1 occurrence in integration tests
The older model was timing out in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /banks/{bank_id}/profileno longer auto-creates banks (changed in fix(api): GET /banks/{bank_id}/profile no longer auto-creates the bank #1287), buttest_memories_timeseries_empty_bank_returns_zero_filled_bucketsstill called it to "ensure the bank exists"Test plan
test_memories_timeseries_empty_bank_returns_zero_filled_bucketspasses locally