fix(openclaw): add WeakSet registration guard keyed by API instance#1409
Merged
nicoloboschi merged 1 commit intovectorize-io:mainfrom May 4, 2026
Merged
fix(openclaw): add WeakSet registration guard keyed by API instance#1409nicoloboschi merged 1 commit intovectorize-io:mainfrom
nicoloboschi merged 1 commit intovectorize-io:mainfrom
Conversation
Adds a WeakSet<MoltbotPluginAPI> guard at the top of the plugin entry function. If the same api object is passed again (registry churn), the entry function exits immediately without re-registering hooks or event listeners. WeakSet is keyed by object identity, not a module-level boolean. A new api object (e.g. after a registry migration) will have a different reference and pass through unconditionally -- this does not reintroduce the bug fixed by vectorize-io#1029 where a module-level boolean blocked new registries from ever getting hooks. Old api objects that are no longer referenced are garbage-collected by the WeakSet (no memory leak). Closes: vectorize-io#1404 Refs: vectorize-io#1029
nicoloboschi
approved these changes
May 4, 2026
liling
pushed a commit
to liling/hindsight
that referenced
this pull request
May 5, 2026
…ectorize-io#1409) Adds a WeakSet<MoltbotPluginAPI> guard at the top of the plugin entry function. If the same api object is passed again (registry churn), the entry function exits immediately without re-registering hooks or event listeners. WeakSet is keyed by object identity, not a module-level boolean. A new api object (e.g. after a registry migration) will have a different reference and pass through unconditionally -- this does not reintroduce the bug fixed by vectorize-io#1029 where a module-level boolean blocked new registries from ever getting hooks. Old api objects that are no longer referenced are garbage-collected by the WeakSet (no memory leak). Closes: vectorize-io#1404 Refs: vectorize-io#1029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a WeakSet guard at the top of the plugin entry function. If the same api object is passed again (registry churn), the entry function exits immediately without re-registering hooks or event listeners.
WeakSet is keyed by object identity, not a module-level boolean. A new api object (e.g. after a registry migration) will have a different reference and pass through unconditionally -- this does not reintroduce the bug fixed by #1029 where a module-level boolean blocked new registries from ever getting hooks.
Old api objects that are no longer referenced are garbage-collected by the WeakSet (no memory leak).
Closes: #1404
Refs: #1029