chore: LLM minimum acceptance tests with CI-managed model matrix#1445
Merged
nicoloboschi merged 3 commits intomainfrom May 5, 2026
Merged
chore: LLM minimum acceptance tests with CI-managed model matrix#1445nicoloboschi merged 3 commits intomainfrom
nicoloboschi merged 3 commits intomainfrom
Conversation
… matrix Move LLM provider/model selection from Python-level pytest.mark.parametrize to a GitHub Actions matrix. Each provider/model combo runs as a separate CI job for clear per-model failure visibility. - Rewrite test_llm_provider.py to read LLM_TEST_PROVIDER/LLM_TEST_MODEL from env vars instead of hardcoded MODEL_MATRIX - Mark with pytest.mark.llm, excluded from test-api via -m "not llm" - Add test-llm-acceptance.yml workflow (daily cron, manual, or 'llm-tests' label) with matrix of 14 provider/model combinations
Replace the Python-level MODEL_MATRIX in test_llm_provider.py with a CI-managed matrix job (test-api-llm-acceptance) in test.yml. - Add hs_llm_mat pytest marker for tests that should run across LLM providers - Tag 6 tests across 5 files covering all core operations: - test_llm_provider.py: API methods + memory operations (fact extraction, reflect) - test_retain.py: test_retain_with_chunks (multi-paragraph retain) - test_fact_extraction_quality.py: test_comprehensive_multi_dimension - test_reflections.py: test_reflect_searches_mental_models_when_available - test_consolidation.py: test_consolidation_merges_only_redundant_facts - test-api excludes hs_llm_mat tests via -m "not hs_llm_mat" - New test-api-llm-acceptance job runs only -m "hs_llm_mat" with matrix: vertexai (gemini-2.5-flash, gemini-2.5-flash-lite), openai (gpt-4.1-mini), anthropic (claude-sonnet-4, claude-haiku-4), deepseek (deepseek-chat)
Matrix: vertexai/gemini-2.5-flash-lite, gemini/gemini-2.5-flash-lite, openai/gpt-4.1-nano, groq/openai-gpt-oss-20b, bedrock/nova-2-lite. Set HINDSIGHT_API_LLM_API_KEY from matrix-provided secret name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_llm_provider.pyto read provider/model fromLLM_TEST_PROVIDER/LLM_TEST_MODELenv vars instead of a Python-levelMODEL_MATRIXwithpytest.mark.parametrizepytest.mark.llmsotest-apiexcludes it via-m "not llm"test-llm-acceptance.ymlworkflow with a CI matrix of 14 provider/model combinations (VertexAI, OpenAI, Anthropic, Groq, DeepSeek, Gemini, Bedrock)llm-testsPR labelAdding/removing models to test is a one-line YAML change in the matrix — no Python changes needed.
Test plan
pytest --collect-only -m "not llm"deselects all 3 LLM testspytest --collect-only tests/test_llm_provider.pycollects 3 testsLLM_TEST_PROVIDER/LLM_TEST_MODELare not settest-apishould pass (LLM tests excluded)llm-testslabel to this PR to validate the new workflow