ci: stop re-running test workflow on pull_request_review#1446
Merged
nicoloboschi merged 1 commit intomainfrom May 5, 2026
Merged
ci: stop re-running test workflow on pull_request_review#1446nicoloboschi merged 1 commit intomainfrom
nicoloboschi merged 1 commit intomainfrom
Conversation
The CI workflow used pull_request_review to re-run secret-requiring jobs after a maintainer approved a fork PR. But pull_request_review fires on every review, so approving an internal PR triggered a duplicate CI run on the same SHA. Drop the pull_request_review trigger and all the conditional gating it required. CI now runs once per push on pull_request. Fork PRs run only the jobs that don't need secrets (gated by has_secrets); to run the full suite on a fork branch, push it to an internal branch or use workflow_dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_reviewfromon:triggers in.github/workflows/test.ymland remove all the conditional gating it required (33!=skips, 17((... approved) ||clauses, theverify-generated-filesfilter, and thereport-pr-statusjob).pull_request_reviewwas originally added so secret-requiring jobs could re-run for fork PRs after a maintainer approved. But the trigger fires on every review, so approving an internal PR (e.g. fix: repair 4 broken tests on main #1437) kicks off a duplicate CI run on the same SHA — wasted CI minutes and noisier checks.pull_request. Fork PRs run only the jobs that don't need secrets (still gated byneeds.detect-changes.outputs.has_secrets). To run the full suite on a fork branch, push it to an internal branch or useworkflow_dispatch.Test plan
has_secrets-gated jobs still run for this internal PR