fix(control-plane): polish zh translation for naturalness#1791
Merged
Conversation
Polish 18 Chinese (zh) translation strings introduced in vectorize-io#1775 to improve fluency and reduce translation artifacts (passive voice, literal renderings, redundant connectives), while preserving the upstream policy of keeping product operation names (Retain / Recall / Reflect / Webhooks) untranslated across all locales. No structural / framework changes. Locale parity tests pass.
nicoloboschi
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes 18 Chinese translation strings in
hindsight-control-plane/src/messages/zh.json(introduced by @nicoloboschi in #1775) for naturalness and fluency. Translation content only — no framework or structural changes.The upstream catalogue is functionally complete (1239 keys aligned with
en.json, all CI parity tests pass), but a few common translation artifacts make several phrases read awkwardly to native zh readers. This PR cleans those up:控制平面→控制面板(login title, metadata description)被将被永久删除→将永久删除配置覆盖for "configuration overrides"自定义配置对…进行 X正在对记忆进行 Reflect→正在 Reflect 记忆将会会一个/通过/关于/以及redundancy)Product operation names (
Retain/Recall/Reflect/Webhooks) are intentionally left untranslated, consistent with the policy already established by #1775 across all 8 locales (en/es/fr/de/pt/ja/ko/zh).Coordination with #1784
I'm aware of @MapleEve's open PR #1784 which removes the generic
zh.jsonin favor ofzh-CN.json/zh-TW.json/yue-Hant.json. Upstream's response timeline on #1784 isn't clear yet, so this PR targets the currently-shippedzh.jsonto deliver the polish to zh users now.If #1784 lands first: I'll happily submit a follow-up PR porting these same 18 polishes to the new
zh-CN.json(and adapt as appropriate forzh-TW/yue-Hantif useful).If this PR lands first: these improvements carry over naturally when #1784 renames
zh.json→zh-CN.json(modulo trivial rebase).Either ordering works; happy to defer to maintainers' preference.
Test plan
npx vitest run src/messages/messages.test.ts— 16/16 tests pass (locale parity, no empty values, key alignment){}placeholders preserved or adjusted to Chinese plural rules (other-only) where appropriatehindsight-control-plane/src/messages/zh.jsoncc @nicoloboschi as the original i18n author for any naming/style preferences I should align with.