fix(control-plane): handle undefined response.data in graph route#239
Merged
nicoloboschi merged 1 commit intovectorize-io:mainfrom Jan 30, 2026
Merged
Conversation
When the backend graph API returns an error, the SDK sets response.data to undefined. NextResponse.json(undefined) throws "Value is not JSON serializable". Check for error/missing data before serializing.
nicoloboschi
approved these changes
Jan 30, 2026
Collaborator
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
we should probably have a way to handle all sdk failures in a single point of the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.databefore JSON serialization in graph routeProblem
When the backend graph API returns an error, the SDK sets
response.datato undefined. CallingNextResponse.json(undefined)throwsValue is not JSON serializable, crashing the control plane.Solution
Check for error or missing data before serializing, return proper error response with 500 status.
Test plan
🤖 Generated with Claude Code