Convert codex tool_choice test to pytest style#752
Merged
nicoloboschi merged 5 commits intomainfrom Mar 30, 2026
Merged
Conversation
Follow-up to #734: replace unittest.TestCase + manual sys.path manipulation with idiomatic pytest + @pytest.mark.asyncio, matching the rest of the test suite.
Update expected count from 20 to 21 and add assertions for fields added by recent PRs: retain_default_strategy, retain_strategies, max_observations_per_scope, reflect_source_facts_max_tokens, llm_gemini_safety_settings, mcp_enabled_tools.
nicoloboschi
force-pushed
the
fix/codex-test-pytest
branch
from
03ea61e to
4d3e7ab
Compare
The LlamaIndex integration doc was added to docs/ (next version) in #672 but not to versioned_docs/version-0.4/, causing a broken link on the /integrations page which resolves to the latest version.
Run generate-docs-skill.sh to pick up new integration pages (codex, llamaindex) and updated configuration docs.
Same issue as LlamaIndex: doc was added to docs/ (next) but not versioned_docs/version-0.4/, causing broken link on /integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_codex_tool_choice.pyfromunittest.TestCase+ manualsys.pathhacking to idiomatic pytest with@pytest.mark.asyncioTest plan
uv run pytest tests/test_codex_tool_choice.py -v— 2 passed