Conversation
Change the metadata index filename from _meta.json to meta.bin in both the documentation comments and the actual implementation to remove the underscore prefix and change the file extension.
- Update test file extension from "_meta.json" to "meta.bin" - This change reflects the actual binary format used for metadata storage
BREAKING CHANGE: Removed environment variable auto-loading for API key and model. Now api_key and model must be explicitly provided through constructor parameters or config file. - Updated Python and Rust Engine constructors to require api_key and model parameters - Removed automatic loading of OPENAI_API_KEY environment variable - Removed configuration priority system for environment variables - Updated README documentation to reflect new required parameters - Added validation to ensure api_key and model are provided before engine initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.