Allow extensionless SSH private keys in picker#5
Merged
Conversation
OpenSSH private keys commonly use names like id_ed25519 without an extension. The native picker was restricted to extension filters, which hid those files and made the public .pub file the visible default path. The picker is now unfiltered and scoped by title so private keys with no suffix or uncommon suffixes can be selected, while the existing import path still reads the selected file content. A focused test covers reading an extensionless private-key file. Constraint: Keep the change limited to the SSH key picker/import path. Rejected: Adding more extensions or relying on a wildcard filter, because rfd filters are extension-based and backend behavior can still hide extensionless names. Confidence: High. Scope-risk: Low; the picker is less restrictive but credential handling is unchanged. Reversibility: Revert src-tauri/src/commands/dialog.rs. Directive: Address the extensionless private key Browse/import bug noted in GitHub issue #3. Tested: npm run build; cargo check -p vibeshell; cargo test -p vibeshell dialog::tests -- --nocapture; rustfmt --edition 2021 --check src-tauri/src/commands/dialog.rs. Not-tested: Manual native dialog click-through on macOS. Related: #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_ed25519are visible by default.Test Plan
npm run buildcargo check -p vibeshellcargo test -p vibeshell dialog::tests -- --nocapturerustfmt --edition 2021 --check src-tauri/src/commands/dialog.rsRefs #3