Skip to content

Conversation

@dr-dimitru
Copy link
Member

@dr-dimitru dr-dimitru commented Mar 2, 2020

  • ☝️ This release focused on compatibility with meteor@1.9.* and node@12.*.*;
  • 🀝 Compatibility with meteor@1.9.*;
  • 🀝 Compatibility with node@12.*.*;
  • πŸ‘¨β€πŸ”¬ Demo autoform-gridfs app is updated and tested agains latest meteor/node.js releases;

Minor:

  • πŸ”₯ Package version v2.3.0 and newer is compatible only with meteor@1.9.* and newer, due to changes in meteor@1.9 and node@12

Fixed:

Updated:

  • πŸ“¦ Remove underscore Atmosphere dependency for good;
  • πŸ“¦ Update ostrio:files Atmosphere dependency to v1.14.0, was v1.13.0

//cc @jankapunkt

- ☝️ This release focused on compatibility with `meteor@1.9.*` and
`node@12.*.*`;
- 🀝 Compatibility with `meteor@1.9.*`;
- 🀝 Compatibility with `node@12.*.*`;
- πŸ‘¨β€πŸ”¬ [Demo autoform-gridfs
app](https://github.com/VeliovGroup/files-gridfs-autoform-example) is
updated and tested agains latest meteor/node.js releases;

__Minor__:
- πŸ”₯ Package version `v2.3.0` and newer are compatible __only__ with
`meteor@1.9.*` and newer, due to changes in `meteor@1.9` and `node@12`

__Fixed__:

- 🐞 Fix issues from #57: *Default insertConfig chunksize and streams
are NaN*, thanks to @jankapunkt;

__Updated__:
- πŸ“¦ __Remove__ `underscore` Atmosphere dependency for good;
- πŸ“¦ Update `ostrio:files` Atmosphere dependency to `v1.14.0`, *was
`v1.13.0`*
@dr-dimitru dr-dimitru requested a review from jankapunkt March 2, 2020 21:36
@dr-dimitru
Copy link
Member Author

@jankapunkt let me know if this one looks good to you

Copy link
Collaborator

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Tested with a Meteor 1.10.1 project and the following configurations:

defaults

  profileImage: {
    type: String,
    autoform: {
      type: 'fileUpload',
      collection: 'Images',
    }
  }

custom templates + accept

  profileImage: {
    type: String,
    autoform: {
      type: 'fileUpload',
      accept: 'image/*,
      collection: 'Images',
      collection: ProfileImages.name,
      uploadTemplate: 'customUpload',
      previewTemplate: 'customPreview'
    }
  }

explicit insertops but using the defaults

  profileImage: {
    type: String,
    autoform: {
      type: 'fileUpload',
      accept: 'image/*,
      collection: 'Images',
      uploadTemplate: 'customUpload',
      previewTemplate: 'customPreview',
      insertConfig: {
        meta: {},
        isBase64: false,
        transport: 'ddp',
        streams: 'dynamic',
        chunkSize: 'dynamic',
        allowWebWorkers: true
      }
    }
  }

explicit invalid streams and chunksize (relevant for #57 ):

  profileImage: {
    type: String,
    autoform: {
      type: 'fileUpload',
      accept: 'image/*,
      collection: 'Images',
      uploadTemplate: 'customUpload',
      previewTemplate: 'customPreview',
      insertConfig: {
        streams: {},
        chunkSize: {},
      }
    }
  }

All no problem with upload, move to gridFs, download and remove.

@dr-dimitru dr-dimitru merged commit 6026f5d into master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants