Skip to content
This repository was archived by the owner on Mar 28, 2022. It is now read-only.

Comments

Merge base fork#5

Open
snikch wants to merge 452 commits intomasterfrom
merge-fork
Open

Merge base fork#5
snikch wants to merge 452 commits intomasterfrom
merge-fork

Conversation

@snikch
Copy link

@snikch snikch commented Dec 3, 2018

This merges sirupsen/logrus@master into our branch. I've tested this in vend/log@levels -> vend/cardinal. Everything seems to be working as expected but it would be good if I can get another DRI to check in their service that it all works as expected.

Damien Mathieu and others added 30 commits July 13, 2017 13:42
Export logger's set level function to address sirupsen#503.
This seems to be one of the most reported issues, as it makes it a lot
harder to safely escape strings.

This option is very much an edge case, and it's causing too much issues
compared to what it provide.
Improve logrus.Entry.Level documentation
Package names shouldn't be using underscores. There is also nothing
wrong with naming this package `syslog`. People can include it with any
name they wish.
Rename logrus_syslog package to syslog
So we don't have a trailing space at the end of each log line
Use buffer length to avoid generating strings every time
readme: remove duplicate godoc link
I'm running logrus on a nacl environment and I get:

```
github.com/sirupsen/logrus/text_formatter.go:70: undefined: IsTerminal
```
IsTerminal should work in nacl too
Closes sirupsen/issues/515

Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
Use x/sys/unix instead of syscall
dgsb and others added 26 commits October 20, 2018 07:09
Fix the version of windows coloring library dependency
Add optional log field with calling method
…-unmarshaler

Make logrus.Level implement encoding.TextUnmarshaler
The panic was caused to a nil pointer access when report
caller was activated with output coloring disabled

Fixes sirupsen#852
@dizaknz
Copy link

dizaknz commented Dec 3, 2018

A few of the tests import github.com/sirupsen/logrus

example_basic_test.go:6:        "github.com/sirupsen/logrus"
example_global_hook_test.go:4:  "github.com/sirupsen/logrus"
example_hook_test.go:9: "github.com/sirupsen/logrus"
example_hook_test.go:10:        slhooks "github.com/sirupsen/logrus/hooks/syslog"
hook_test.go:12:        . "github.com/sirupsen/logrus"
hook_test.go:13:        . "github.com/sirupsen/logrus/internal/testutils"
internal/testutils/testutils.go:10:     . "github.com/sirupsen/logrus"
logrus_test.go:16:      . "github.com/sirupsen/logrus"
logrus_test.go:17:      . "github.com/sirupsen/logrus/internal/testutils"
logrus_test.go:41:                      "github.com/sirupsen/logrus_test.TestReportCallerWhenConfigured.func3", fields["func"])
logrus_test.go:348:             "github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller", fields["func"])
logrus_test.go:378:             "github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller", fields["func"])

@dizaknz
Copy link

dizaknz commented Dec 3, 2018

👍 59f8d88 - fixed

@dizaknz
Copy link

dizaknz commented Dec 3, 2018

Tested locally on shifta and seems all good. Just required a dep ensure to vendor golang.org/x/crypto/ssh/terminal

@dizaknz
Copy link

dizaknz commented Dec 3, 2018

Seems okay, except for one test failure (as you've already noted)

 go test $(go list ./... | grep -v /vendor/)

ok      github.com/vend/logrus  0.436s
?       github.com/vend/logrus/examples/basic   [no test files]
--- FAIL: TestLogstashFormatter (0.00s)
        logstash_test.go:46: 
                        Error Trace:    logstash_test.go:46
                        Error:          Not equal: 
                                        expected: string("Get http://example.com The error")
                                        actual  : map[string]interface {}(map[string]interface {}{"Op":"Get", "URL":"http://example.com", "Err":map[string]interface {}{}})
                        Test:           TestLogstashFormatter
FAIL
FAIL    github.com/vend/logrus/formatters/logstash      0.017s
ok      github.com/vend/logrus/hooks/syslog     0.019s
ok      github.com/vend/logrus/hooks/test       0.026s
?       github.com/vend/logrus/internal/testutils       [no test files]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.