This repository was archived by the owner on Mar 28, 2022. It is now read-only.
Open
Conversation
Export logger's set level function to address sirupsen#503.
This seems to be one of the most reported issues, as it makes it a lot harder to safely escape strings. This option is very much an edge case, and it's causing too much issues compared to what it provide.
Remove QuoteCharacter option
Improve logrus.Entry.Level documentation
Package names shouldn't be using underscores. There is also nothing wrong with naming this package `syslog`. People can include it with any name they wish.
Rename logrus_syslog package to syslog
Test all subpackages too
So we don't have a trailing space at the end of each log line
Fix trailing space
Use buffer length to avoid generating strings every time
readme: remove duplicate godoc link
I'm running logrus on a nacl environment and I get: ``` github.com/sirupsen/logrus/text_formatter.go:70: undefined: IsTerminal ```
IsTerminal should work in nacl too
Closes sirupsen/issues/515 Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
Use x/sys/unix instead of syscall
Fix golint issues in formatters
…velLogging Added TRACE level logging.
Fix the version of windows coloring library dependency
Add optional log field with calling method
…-unmarshaler Make logrus.Level implement encoding.TextUnmarshaler
The panic was caused to a nil pointer access when report caller was activated with output coloring disabled Fixes sirupsen#852
fix panic in text formatter
Add GELF to third party formatters
Attempt to fix build break on aix
Fix hook example
|
A few of the tests import |
|
👍 59f8d88 - fixed |
|
Tested locally on |
|
Seems okay, except for one test failure (as you've already noted) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges
sirupsen/logrus@masterinto our branch. I've tested this invend/log@levels->vend/cardinal. Everything seems to be working as expected but it would be good if I can get another DRI to check in their service that it all works as expected.