Conversation
📝 WalkthroughWalkthroughAdds a migration-aware helper Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Messaging/Typing Flow
participant Wrapper as createWidWrapper
participant Store as Store / WidFactory / Chat
participant Channel as ChannelUtils / NewsletterCollection
participant Sync as WAWebContactSyncUtils
Caller->>Wrapper: createWidWrapper(chatId)
Wrapper->>Store: create Wid(chatId)
alt Migration gate enabled
Wrapper->>Channel: try loadNewsletterPreviewChat / channel lookup
alt Newsletter/channel found
Channel-->>Wrapper: newsletter chatWid
else not found
Wrapper->>Store: findOrCreateLatestChat(chatWid)
alt found
Store-->>Wrapper: chatWid
else not found
Wrapper->>Sync: build + execute contact-add delta
Sync-->>Wrapper: response with created chatWid
end
end
else Migration gate disabled
Wrapper-->>Store: return created Wid or fallback chatWid
end
Wrapper-->>Caller: resolved chatWid
Caller->>Store: perform send/typing/image/button operation with chatWid
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used📓 Path-based instructions (1)src/lib/wapi/**/*.js📄 CodeRabbit inference engine (CLAUDE.md)
Files:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/lib/wapi/helper/fix-lid-migration.js (1)
1-12: Add JSDoc to explain LID migration normalization.The function lacks documentation explaining what LID migration is, the expected input format, and the transformation behavior.
📝 Suggested JSDoc
+/** + * Normalizes LID (Local Identifier) migration format for WhatsApp identifiers. + * Converts identifiers in the format "digits:digits@lid" to "digits@lid". + * + * @param {string} number - The chat or contact identifier to normalize + * @returns {string} The normalized identifier, or the original if not an LID format + * @example + * fixLidMigration("1234:5678@lid") // returns "1234@lid" + * fixLidMigration("1234567890@c.us") // returns "1234567890@c.us" + */ export function fixLidMigration(number) {
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/lib/wapi/functions/send-message.jssrc/lib/wapi/functions/simulate-typing.jssrc/lib/wapi/helper/fix-lid-migration.jssrc/lib/wapi/helper/index.js
🧰 Additional context used
📓 Path-based instructions (2)
src/lib/wapi/functions/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI functions in src/lib/wapi/functions are JavaScript files injected into the browser; after changing them, run
npm run build:wapito rebuild
Files:
src/lib/wapi/functions/send-message.jssrc/lib/wapi/functions/simulate-typing.js
src/lib/wapi/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI layer code is built with webpack and injected into the Puppeteer browser context
Files:
src/lib/wapi/functions/send-message.jssrc/lib/wapi/functions/simulate-typing.jssrc/lib/wapi/helper/index.jssrc/lib/wapi/helper/fix-lid-migration.js
🧠 Learnings (1)
📚 Learning: 2025-09-08T17:49:03.345Z
Learnt from: CR
Repo: venomlib/venom PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-08T17:49:03.345Z
Learning: Applies to src/lib/wapi/functions/**/*.js : WAPI functions in src/lib/wapi/functions are JavaScript files injected into the browser; after changing them, run `npm run build:wapi` to rebuild
Applied to files:
src/lib/wapi/helper/index.js
🧬 Code graph analysis (2)
src/lib/wapi/functions/send-message.js (2)
src/lib/wapi/functions/check-send-exist.js (1)
to(15-15)src/lib/wapi/helper/fix-lid-migration.js (1)
fixLidMigration(1-12)
src/lib/wapi/functions/simulate-typing.js (1)
src/lib/wapi/helper/fix-lid-migration.js (1)
fixLidMigration(1-12)
🔇 Additional comments (5)
src/lib/wapi/helper/index.js (1)
10-10: LGTM!The export follows the established pattern and correctly exposes the new helper function.
src/lib/wapi/functions/simulate-typing.js (2)
1-3: LID migration normalization applied correctly.The integration properly normalizes the
chatIdbefore creating the Wid. However, ensure the upstream issues infixLidMigration(empty string return and missing input validation) are addressed to preventcreateWidfrom receiving invalid inputs.
1-14: Reminder: Rebuild WAPI after changes.After modifying WAPI functions, run
npm run build:wapito rebuild the injected browser context code.As per coding guidelines.
src/lib/wapi/functions/send-message.js (2)
1-1: LID migration normalization integrated correctly.The normalization is applied to the recipient number before chat resolution. However, be aware that if
fixLidMigrationreturns an empty string for malformed inputs (currently an issue), it could bypass the validation at lines 28-30, potentially causing failures insendExistorreturnChat.Also applies to: 32-32
1-154: Reminder: Rebuild WAPI after changes.After modifying WAPI functions, run
npm run build:wapito rebuild the injected browser context code.As per coding guidelines.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/lib/wapi/functions/simulate-typing.js
🧰 Additional context used
📓 Path-based instructions (2)
src/lib/wapi/functions/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI functions in src/lib/wapi/functions are JavaScript files injected into the browser; after changing them, run
npm run build:wapito rebuild
Files:
src/lib/wapi/functions/simulate-typing.js
src/lib/wapi/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI layer code is built with webpack and injected into the Puppeteer browser context
Files:
src/lib/wapi/functions/simulate-typing.js
🧬 Code graph analysis (1)
src/lib/wapi/functions/simulate-typing.js (1)
src/lib/wapi/helper/fix-lid-migration.js (1)
fixLidMigration(1-14)
🔇 Additional comments (2)
src/lib/wapi/functions/simulate-typing.js (2)
1-15: Reminder: Rebuild WAPI functions after changes.As per coding guidelines, WAPI functions must be rebuilt after modification. Please run
npm run build:wapito ensure the changes are properly bundled for injection into the browser context.
1-1: The import is correct and properly exported.The
fixLidMigrationhelper is correctly exported from../helper/index.jsand properly imported here. Since this is a WAPI function, remember to runnpm run build:wapiafter making changes to rebuild the injected code.
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/lib/wapi/functions/simulate-typing.js (1)
4-14: Missingawaiton async function call causes runtime failure.
createWidWrapperis an async function, but line 4 calls it withoutawait. This causes:
chatto be aPromiseobject instead of the resolvedWid- The
if (!chat)check at line 5 will always be false (Promises are truthy)Store.ChatState.sendChatStateComposing(chat)at line 13 will receive a Promise instead of a Wid, likely causing an error🔎 Proposed fix
- const chat = createWidWrapper(chatId); + const chat = await createWidWrapper(chatId);src/lib/wapi/functions/get-chat.js (1)
22-47:sendMessageaugmentation skipped for newly created chats.The
sendMessagemethod is only added in theelseblock (lines 41-47), which only executes whenfoundis truthy. However, when a chat is created in theifblock (lines 22-40),foundwill be the newly created chat, and the code won't reach theelseblock. This means newly created chats won't have thesendMessagemethod augmented.🔎 Proposed fix
Move the sendMessage augmentation outside the if/else, or add it in both branches:
found = Store.Chat.find(ConstructChat) || false; } - } else { + } + + if (found) { found.sendMessage = found.sendMessage ? found.sendMessage : function () { return window.Store.sendMessage.apply(this, arguments); }; } return found;
♻️ Duplicate comments (1)
src/lib/wapi/functions/simulate-typing.js (1)
3-3: Debug logging already flagged in previous review.This
console.logstatement was already identified in a previous review and should be removed or guarded behind a debug flag.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
src/lib/wapi/business/send-message-with-buttons.jssrc/lib/wapi/functions/get-chat.jssrc/lib/wapi/functions/index.jssrc/lib/wapi/functions/send-image-with-product.jssrc/lib/wapi/functions/send-message.jssrc/lib/wapi/functions/send-message2.jssrc/lib/wapi/functions/simulate-typing.jssrc/lib/wapi/helper/fix-lid-migration.jssrc/lib/wapi/helper/index.jssrc/lib/wapi/store/store-objects.jssrc/lib/wapi/wapi.js
💤 Files with no reviewable changes (3)
- src/lib/wapi/functions/index.js
- src/lib/wapi/functions/send-message2.js
- src/lib/wapi/wapi.js
🚧 Files skipped from review as they are similar to previous changes (2)
- src/lib/wapi/helper/index.js
- src/lib/wapi/functions/send-message.js
🧰 Additional context used
📓 Path-based instructions (2)
src/lib/wapi/functions/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI functions in src/lib/wapi/functions are JavaScript files injected into the browser; after changing them, run
npm run build:wapito rebuild
Files:
src/lib/wapi/functions/send-image-with-product.jssrc/lib/wapi/functions/get-chat.jssrc/lib/wapi/functions/simulate-typing.js
src/lib/wapi/**/*.js
📄 CodeRabbit inference engine (CLAUDE.md)
WAPI layer code is built with webpack and injected into the Puppeteer browser context
Files:
src/lib/wapi/functions/send-image-with-product.jssrc/lib/wapi/store/store-objects.jssrc/lib/wapi/business/send-message-with-buttons.jssrc/lib/wapi/helper/fix-lid-migration.jssrc/lib/wapi/functions/get-chat.jssrc/lib/wapi/functions/simulate-typing.js
🧠 Learnings (1)
📚 Learning: 2025-09-08T17:49:03.345Z
Learnt from: CR
Repo: venomlib/venom PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-08T17:49:03.345Z
Learning: Applies to src/lib/wapi/functions/**/*.js : WAPI functions in src/lib/wapi/functions are JavaScript files injected into the browser; after changing them, run `npm run build:wapi` to rebuild
Applied to files:
src/lib/wapi/functions/send-image-with-product.js
🧬 Code graph analysis (6)
src/lib/wapi/functions/send-image-with-product.js (1)
src/lib/wapi/helper/fix-lid-migration.js (1)
createWidWrapper(1-42)
src/lib/wapi/store/store-objects.js (3)
src/lib/wapi/wapi.js (1)
module(166-166)src/api/helpers/callback-wile.ts (1)
module(39-41)src/lib/wapi/store/get-store.js (1)
module(34-34)
src/lib/wapi/business/send-message-with-buttons.js (1)
src/lib/wapi/helper/fix-lid-migration.js (1)
createWidWrapper(1-42)
src/lib/wapi/helper/fix-lid-migration.js (2)
src/lib/wapi/functions/get-chat.js (3)
gate(9-11)chatWid(15-15)chatWid(28-28)src/lib/wapi/functions/simulate-typing.js (1)
chat(4-4)
src/lib/wapi/functions/get-chat.js (1)
src/lib/wapi/helper/fix-lid-migration.js (3)
gate(2-4)chatWid(6-6)createWidWrapper(1-42)
src/lib/wapi/functions/simulate-typing.js (1)
src/lib/wapi/helper/fix-lid-migration.js (2)
chat(10-10)createWidWrapper(1-42)
🔇 Additional comments (2)
src/lib/wapi/business/send-message-with-buttons.js (1)
108-113: LGTM!The async/await handling is correct. The
.then()handler is properly marked asasync(line 108) andcreateWidWrapperis correctly awaited (line 113).src/lib/wapi/store/store-objects.js (1)
221-230: LGTM!The new store object entries for
ChannelUtilsandFindOrCreateChatare correctly structured and follow the existing pattern. The conditional checks match the methods used insrc/lib/wapi/helper/fix-lid-migration.js(lines 16 and 23).
1 participant
Fixes # .
Changes proposed in this pull request
To test (it takes a while):
npm install github:<username>/venom#<branch>Summary by CodeRabbit
New Features
Bug Fixes
Breaking Changes
✏️ Tip: You can customize this high-level summary in your review settings.